Merge lp:~ken-vandine/ubuntu-system-settings/lp1535827 into lp:ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1584
Merged at revision: 1584
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/lp1535827
Merge into: lp:ubuntu-system-settings
Diff against target: 38 lines (+11/-4)
1 file modified
plugins/bluetooth/PageComponent.qml (+11/-4)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/lp1535827
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+283216@code.launchpad.net

Commit message

Don't display the ActivityIndicator while searching, causes to much load.

Description of the change

Don't display the ActivityIndicator while searching, causes to much load.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM and works. Thanks!

review: Approve
1585. By Ken VanDine

Display Searching text when discovering, not discoverable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/bluetooth/PageComponent.qml'
--- plugins/bluetooth/PageComponent.qml 2015-11-20 08:47:27 +0000
+++ plugins/bluetooth/PageComponent.qml 2016-01-21 14:21:33 +0000
@@ -266,14 +266,15 @@
266 enabled: false266 enabled: false
267 }267 }
268268
269 ActivityIndicator {269 Label {
270 anchors {270 anchors {
271 top: parent.top271 top: parent.top
272 right: parent.right272 right: parent.right
273 topMargin: units.gu(1)273 topMargin: units.gu(1)
274 }274 }
275 color: "darkgrey"
275 visible: backend.powered && !backend.discoverable276 visible: backend.powered && !backend.discoverable
276 running: visible277 text: i18n.tr("Searching…")
277 }278 }
278 }279 }
279 }280 }
@@ -319,9 +320,15 @@
319 id: disconnectedHeader320 id: disconnectedHeader
320 text: connectedList.visible ? i18n.tr("Connect another device:") : i18n.tr("Connect a device:")321 text: connectedList.visible ? i18n.tr("Connect another device:") : i18n.tr("Connect a device:")
321 enabled: bluetoothActionGroup.enabled.state != undefined ? bluetoothActionGroup.enabled.state : false322 enabled: bluetoothActionGroup.enabled.state != undefined ? bluetoothActionGroup.enabled.state : false
322 control: ActivityIndicator {323 control: Label {
324 anchors {
325 top: parent.top
326 right: parent.right
327 topMargin: units.gu(1)
328 }
329 color: "darkgrey"
323 visible: backend.powered && backend.discovering330 visible: backend.powered && backend.discovering
324 running: visible331 text: i18n.tr("Searching…")
325 }332 }
326 }333 }
327334

Subscribers

People subscribed via source and target branches