Code review comment for lp:~ken-vandine/ubuntu-system-settings/lp1489389

Revision history for this message
Ken VanDine (ken-vandine) wrote :

> There's a “Rebooting” event from the SystemImage Service dbus object. I'm not
> sure what would prevent a reboot, but if it's because /sbin/reboot -f fails,
> we could check if the event has been fired and try again (after n seconds) if
> not? 30 secs seems random.

onRebooting is emitted when Rebooting is emitted from SystemImage dbus service. I'm not sure what conditions would cause system-image-dbus from rebooting the device, but I have seen a simple reattempt work. We are getting the signal reliably, because the "Restarting" label is being displayed. When it fails to reboot, you are just stuck on the "Restarting" view.

30 seconds is rather arbitrary. Some devices (arale and krilling) reboot instantly, but I have seen mako take much longer, perhaps even 10 seconds. I'd be happy to shorten the timer if you like.

« Back to merge proposal