Code review comment for lp:~ken-vandine/ubuntu-system-settings/lp1438633

Revision history for this message
Ken VanDine (ken-vandine) wrote :

> Thanks, but that looks like a workaround rather than a real fix, we should
> keep looking for the real bug there... also if we think that change is right,
> shouldn't we do the same for the regularitory info subscreen in the same
> source?

It's a fix because it prevents us from pushing an object on the PageStack that is null. It doesn't really fix why it was null before, I'd like to figure that out too, but so far no luck. It would be good to add the same protection for regulatory page too.

« Back to merge proposal