Code review comment for lp:~ken-vandine/telepathy-indicator/lp_1046360

Revision history for this message
Lars Karlitski (larsu) wrote :

Works, but has a memory leak in check_enabled_accounts:

tp_account_manager_dup_valid_accounts returns a list of reffed TpAccounts. Instead of using g_list_free, the returned list should be freed with

  g_list_free_full (account_list, g_object_unref)

to unref the contained accounts.

Also, the `g_list_free (account_service_list)` can be removed, it doesn't free anything (account_service_list is NULL after the loop has run through).


review: Needs Fixing

« Back to merge proposal