Looking good overall. Two remarks:
1) Can you add a simple serialization test to test-previews.vala?
2) This should be removed?: 176 + 177 +/* KEN 178 + public SocialPreview (Comment[] comments, string selected_item_uri) 179 + { 180 + // careful current_item_uri will be set before items are 181 + Object (current_item_uri: selected_item_uri); 182 + foreach (unowned Comment comment in comments) 183 + { 184 + add_comment (comment); 185 + } 186 + } 187 +*/
« Back to merge proposal
Looking good overall. Two remarks:
1) Can you add a simple serialization test to test-previews.vala?
2) This should be removed?:
176 +
177 +/* KEN
178 + public SocialPreview (Comment[] comments, string selected_item_uri)
179 + {
180 + // careful current_item_uri will be set before items are
181 + Object (current_item_uri: selected_item_uri);
182 + foreach (unowned Comment comment in comments)
183 + {
184 + add_comment (comment);
185 + }
186 + }
187 +*/