Merge lp:~ken-vandine/libqofono/0.90-suggests into lp:~phablet-team/libqofono/ubuntu

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 217
Merged at revision: 216
Proposed branch: lp:~ken-vandine/libqofono/0.90-suggests
Merge into: lp:~phablet-team/libqofono/ubuntu
Prerequisite: lp:~ken-vandine/libqofono/0.90
Diff against target: 25 lines (+3/-1)
2 files modified
debian/changelog (+2/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/libqofono/0.90-suggests
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
Review via email: mp+304655@code.launchpad.net

Commit message

Dropped recommends for ofono to a suggests

Description of the change

Dropped recommends for ofono to a suggests

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

I'm not sure I understand the consequence of this. How will libqofono behave without ofono? Will it segfault?

I'm sure you've thought that out, though, so +1 :)

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

> I'm not sure I understand the consequence of this. How will libqofono behave
> without ofono? Will it segfault?
>
> I'm sure you've thought that out, though, so +1 :)

just reports no modems

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2016-09-01 14:57:01 +0000
+++ debian/changelog 2016-09-01 14:57:01 +0000
@@ -1,6 +1,8 @@
1libqofono (0.90-0ubuntu1) UNRELEASED; urgency=medium1libqofono (0.90-0ubuntu1) UNRELEASED; urgency=medium
22
3 * New upstream release3 * New upstream release
4 * debian/control
5 - Dropped recommends for ofono to a suggests
46
5 -- Ken VanDine <ken.vandine@canonical.com> Wed, 23 Mar 2016 15:13:06 -04007 -- Ken VanDine <ken.vandine@canonical.com> Wed, 23 Mar 2016 15:13:06 -0400
68
79
=== modified file 'debian/control'
--- debian/control 2016-01-27 14:14:55 +0000
+++ debian/control 2016-09-01 14:57:01 +0000
@@ -18,7 +18,7 @@
18Multi-Arch: same18Multi-Arch: same
19Depends: ${shlibs:Depends},19Depends: ${shlibs:Depends},
20 ${misc:Depends},20 ${misc:Depends},
21Recommends: ofono (>= 1.16),21Suggests: ofono (>= 1.16),
22Description: Qt library for Ofono22Description: Qt library for Ofono
23 A library for accessing the ofono daemon, and a declarative plugin for 23 A library for accessing the ofono daemon, and a declarative plugin for
24 it. This allows accessing ofono in qtquick and friends.24 it. This allows accessing ofono in qtquick and friends.

Subscribers

People subscribed via source and target branches