Merge lp:~ken-vandine/indicator-sound/libnotify_and_dbusmenu_change into lp:~indicator-applet-developers/indicator-sound/trunk_3

Proposed by Ken VanDine
Status: Merged
Merged at revision: 199
Proposed branch: lp:~ken-vandine/indicator-sound/libnotify_and_dbusmenu_change
Merge into: lp:~indicator-applet-developers/indicator-sound/trunk_3
Diff against target: 79 lines (+3/-17)
5 files modified
configure.ac (+1/-1)
src/Makefile.am (+1/-1)
src/indicator-sound.c (+0/-2)
src/sound-state-manager.c (+1/-11)
src/sound-state-manager.h (+0/-2)
To merge this branch: bzr merge lp:~ken-vandine/indicator-sound/libnotify_and_dbusmenu_change
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+49404@code.launchpad.net

Description of the change

Ported to libnotify4-dev >= 0.7 and handle the Dbusmenu-Glib-0.4 rename to Dbusmenu-0.4

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2011-02-10 14:35:59 +0000
+++ configure.ac 2011-02-11 15:27:16 +0000
@@ -35,7 +35,7 @@
35INDICATOR_DISPLAY_OBJECTS=0.1.1135INDICATOR_DISPLAY_OBJECTS=0.1.11
36DBUSMENUGLIB_REQUIRED_VERSION=0.3.936DBUSMENUGLIB_REQUIRED_VERSION=0.3.9
37GIO_2_0_REQUIRED_VERSION=2.25.1337GIO_2_0_REQUIRED_VERSION=2.25.13
38LIBNOTIFY_REQUIRED_VERSION=0.5.038LIBNOTIFY_REQUIRED_VERSION=0.7.0
3939
40PKG_CHECK_MODULES(APPLET, gtk+-2.0 >= $GTK_REQUIRED_VERSION40PKG_CHECK_MODULES(APPLET, gtk+-2.0 >= $GTK_REQUIRED_VERSION
41 indicator >= $INDICATOR_REQUIRED_VERSION41 indicator >= $INDICATOR_REQUIRED_VERSION
4242
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2011-02-04 16:17:31 +0000
+++ src/Makefile.am 2011-02-11 15:27:16 +0000
@@ -65,7 +65,7 @@
65 --vapidir=./ \65 --vapidir=./ \
66 --thread \66 --thread \
67 --pkg gee-1.0 \67 --pkg gee-1.0 \
68 --pkg Dbusmenu-Glib-0.4 \68 --pkg Dbusmenu-0.4 \
69 --pkg common-defs \69 --pkg common-defs \
70 --pkg gio-2.0 \70 --pkg gio-2.0 \
71 --pkg gio-unix-2.0 \71 --pkg gio-unix-2.0 \
7272
=== modified file 'src/indicator-sound.c'
--- src/indicator-sound.c 2011-02-02 19:05:50 +0000
+++ src/indicator-sound.c 2011-02-11 15:27:16 +0000
@@ -401,8 +401,6 @@
401 newitem,401 newitem,
402 menu_volume_item,402 menu_volume_item,
403 parent);403 parent);
404 sound_state_manager_attach_notification_to_volume_widget (priv->state_manager,
405 volume_widget);
406 return TRUE;404 return TRUE;
407}405}
408406
409407
=== modified file 'src/sound-state-manager.c'
--- src/sound-state-manager.c 2011-02-02 19:05:50 +0000
+++ src/sound-state-manager.c 2011-02-11 15:27:16 +0000
@@ -151,23 +151,13 @@
151 }151 }
152152
153 if (has_notify_osd) {153 if (has_notify_osd) {
154 priv->notification = notify_notification_new(PACKAGE_NAME, NULL, NULL, NULL);154 priv->notification = notify_notification_new(PACKAGE_NAME, NULL, NULL);
155 notify_notification_set_hint_string(priv->notification,155 notify_notification_set_hint_string(priv->notification,
156 "x-canonical-private-synchronous", "");156 "x-canonical-private-synchronous", "");
157 }157 }
158}158}
159159
160void160void
161sound_state_manager_attach_notification_to_volume_widget (SoundStateManager *self,
162 GtkWidget* volume_widget)
163{
164 SoundStateManagerPrivate* priv = SOUND_STATE_MANAGER_GET_PRIVATE(self);
165 if (priv->notification)
166 notify_notification_attach_to_widget(priv->notification, volume_widget);
167}
168
169
170void
171sound_state_manager_show_notification (SoundStateManager *self,161sound_state_manager_show_notification (SoundStateManager *self,
172 double value)162 double value)
173{163{
174164
=== modified file 'src/sound-state-manager.h'
--- src/sound-state-manager.h 2011-02-02 19:05:50 +0000
+++ src/sound-state-manager.h 2011-02-11 15:27:16 +0000
@@ -61,8 +61,6 @@
61void sound_state_manager_show_notification (SoundStateManager *self,61void sound_state_manager_show_notification (SoundStateManager *self,
62 double value);62 double value);
6363
64void sound_state_manager_attach_notification_to_volume_widget (SoundStateManager *self,
65 GtkWidget* volume_widget);
6664
67G_END_DECLS65G_END_DECLS
6866

Subscribers

People subscribed via source and target branches