Code review comment for lp:~ken-vandine/indicator-me/gdbus

Revision history for this message
Ted Gould (ted) wrote :

conncetion_changed()

Should really check to see if status_proxy_cancel is NULL as well so that you don't allocate two of them.

status_proxy_cb()

You shouldn't cast the user_data to self before checking the error. There is a few cases where the indicator could be deallocated before this function is called and therefore user_data would be a random pointer.

review: Needs Fixing

« Back to merge proposal