Merge lp:~ken-vandine/gsettings-qt/lp1349787_tests into lp:gsettings-qt

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 66
Merged at revision: 62
Proposed branch: lp:~ken-vandine/gsettings-qt/lp1349787_tests
Merge into: lp:gsettings-qt
Prerequisite: lp:~larsu/gsettings-qt/lp1349787
Diff against target: 35 lines (+9/-0)
2 files modified
tests/com.canonical.gsettings.test.gschema.xml (+3/-0)
tests/tst_GSettings.qml (+6/-0)
To merge this branch: bzr merge lp:~ken-vandine/gsettings-qt/lp1349787_tests
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Jonas G. Drange (community) Approve
Review via email: mp+229258@code.launchpad.net

Commit message

added tests for a{ss}

Description of the change

added tests for a{ss}

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/com.canonical.gsettings.test.gschema.xml'
--- tests/com.canonical.gsettings.test.gschema.xml 2013-07-19 12:07:43 +0000
+++ tests/com.canonical.gsettings.test.gschema.xml 2014-08-01 16:49:03 +0000
@@ -24,5 +24,8 @@
24 <key name="test-string-list" type="as">24 <key name="test-string-list" type="as">
25 <default>['one', 'two', 'three']</default>25 <default>['one', 'two', 'three']</default>
26 </key>26 </key>
27 <key name="test-map" type="a{ss}">
28 <default>{'foo': 'one', 'bar': 'two'}</default>
29 </key>
27 </schema>30 </schema>
28</schemalist>31</schemalist>
2932
=== modified file 'tests/tst_GSettings.qml'
--- tests/tst_GSettings.qml 2014-04-08 09:28:52 +0000
+++ tests/tst_GSettings.qml 2014-08-01 16:49:03 +0000
@@ -31,6 +31,7 @@
31 compare(settings.testBoolean, false);31 compare(settings.testBoolean, false);
32 compare(settings.testString, 'hello');32 compare(settings.testString, 'hello');
33 compare(settings.testStringList, ['one', 'two', 'three']);33 compare(settings.testStringList, ['one', 'two', 'three']);
34 compare(settings.testMap, {'foo': 'one', 'bar': 'two'});
3435
35 compare(testCase.bindingTest, 'hello');36 compare(testCase.bindingTest, 'hello');
36 }37 }
@@ -53,6 +54,11 @@
53 settings.testStringList = [];54 settings.testStringList = [];
54 compare(settings.testStringList, []);55 compare(settings.testStringList, []);
5556
57 settings.testMap = {'baz': 'three'}
58 compare(settings.testMap, {'baz': 'three'});
59 settings.testMap = {};
60 compare(settings.testMap, {});
61
56 settings.testEnum = 'two';62 settings.testEnum = 'two';
57 compare(settings.testEnum, 'two');63 compare(settings.testEnum, 'two');
5864

Subscribers

People subscribed via source and target branches

to all changes: