Merge lp:~ken-vandine/gsettings-qt/lp1349787_tests into lp:gsettings-qt

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 66
Merged at revision: 62
Proposed branch: lp:~ken-vandine/gsettings-qt/lp1349787_tests
Merge into: lp:gsettings-qt
Prerequisite: lp:~larsu/gsettings-qt/lp1349787
Diff against target: 35 lines (+9/-0)
2 files modified
tests/com.canonical.gsettings.test.gschema.xml (+3/-0)
tests/tst_GSettings.qml (+6/-0)
To merge this branch: bzr merge lp:~ken-vandine/gsettings-qt/lp1349787_tests
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Jonas G. Drange (community) Approve
Review via email: mp+229258@code.launchpad.net

Commit message

added tests for a{ss}

Description of the change

added tests for a{ss}

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/com.canonical.gsettings.test.gschema.xml'
2--- tests/com.canonical.gsettings.test.gschema.xml 2013-07-19 12:07:43 +0000
3+++ tests/com.canonical.gsettings.test.gschema.xml 2014-08-01 16:49:03 +0000
4@@ -24,5 +24,8 @@
5 <key name="test-string-list" type="as">
6 <default>['one', 'two', 'three']</default>
7 </key>
8+ <key name="test-map" type="a{ss}">
9+ <default>{'foo': 'one', 'bar': 'two'}</default>
10+ </key>
11 </schema>
12 </schemalist>
13
14=== modified file 'tests/tst_GSettings.qml'
15--- tests/tst_GSettings.qml 2014-04-08 09:28:52 +0000
16+++ tests/tst_GSettings.qml 2014-08-01 16:49:03 +0000
17@@ -31,6 +31,7 @@
18 compare(settings.testBoolean, false);
19 compare(settings.testString, 'hello');
20 compare(settings.testStringList, ['one', 'two', 'three']);
21+ compare(settings.testMap, {'foo': 'one', 'bar': 'two'});
22
23 compare(testCase.bindingTest, 'hello');
24 }
25@@ -53,6 +54,11 @@
26 settings.testStringList = [];
27 compare(settings.testStringList, []);
28
29+ settings.testMap = {'baz': 'three'}
30+ compare(settings.testMap, {'baz': 'three'});
31+ settings.testMap = {};
32+ compare(settings.testMap, {});
33+
34 settings.testEnum = 'two';
35 compare(settings.testEnum, 'two');
36

Subscribers

People subscribed via source and target branches

to all changes: