Code review comment for lp:~ken-vandine/friends/fix-facebook-name

Revision history for this message
Robert Bruce Park (robru) wrote :

On 12-10-26 06:52 PM, Ken VanDine wrote:
> Oh, sender_id wasn't used. I don't see a reason to store it. I don't know if we have a place where we need to use it at all. I would say lets just keep it the same as name.

Alright, fair. I can see it being needed if we wanted to present a link
to that person's profile, but if you don't intend to have such a link,
then there's no need. If we later decided we wanted to link to people's
profile pages, we could add a new model schema called 'sender_url' or
'sender_profile' or something, and just fill it with
PERMALINK.format(id=sender_id) quite easily.

« Back to merge proposal