Code review comment for lp:~ken-vandine/friends/fix-facebook-name

On 12-10-26 06:01 PM, Ken VanDine wrote:
> from_record = entry.get('from')
> if from_record is not None:
> - args['sender'] = sender_id = from_record.get('id', '')
> + args['sender'] = from_record.get('name', '')
> + sender_id = from_record.get('id', '')
> args['icon_uri'] = Avatar.get_image(
> API_BASE.format(id=sender_id) + '/picture?type=large')
> args['sender_nick'] = from_record.get('name', '')

Ken, I had noticed this problem earlier, but I'm not sure how to handle
it. Your change makes sender_nick and sender set to the same value... is
that ok? Also, you're not storing the sender_id anywhere. Are you sure
we won't need that later for anything?

I know Facebook doesn't really have a concept of nicknames (at least not
like twitter has screen names vs display names), although some people do
have id's that aren't just random numbers. Maybe we should store the
facebook id in the sender_nick column?

Also, you have one extra space next to the equal sign, please fix that ;-)