Code review comment for lp:~ken-vandine/content-hub/download-manager-with-snapdecision

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * Yes
   - https://code.launchpad.net/~michael-sheldon/content-hub/download-manager-integration/+merge/217788

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * This change adds a snap decision notification. This was added as an interim
   solution until we have final designs.

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * Yes, just added libnotify as a build depends. I'm a core-dev.

« Back to merge proposal