Code review comment for lp:~ken-pepple/nova/dynamicinstancetypes

Revision history for this message
Eric Day (eday) wrote :

Just one little thing, you shouldn't put your email address in the
copyright line. Email addresses should go in the Authors file. :)

-Eric

On Tue, Mar 01, 2011 at 06:27:57PM -0000, Ken Pepple wrote:
> okay, i am going to add "Copyright 2011 Ken Pepple <email address hidden>" to the following files:
>
> - doc/source/runnova/managing.instance.types.rst
> - nova/db/sqlalchemy/migrate_repo/versions/007_add_instance_types.py
> - nova/compute/instance_types.py (leaving the current ones also)
> - nova/tests/test_instance_types.py
>
> i'll wait to push this until others have weighed in.
> --
> https://code.launchpad.net/~ken-pepple/nova/dynamicinstancetypes/+merge/50257
> Your team Nova Core is requested to review the proposed merge of lp:~ken-pepple/nova/dynamicinstancetypes into lp:nova.

« Back to merge proposal