Code review comment for lp:~ken-brotherton/boots/localization

Revision history for this message
KenBrotherton (ken-brotherton) wrote :

Ripped straight from an example? Munges? Steps on? Can you be more
specific? All the testing that I did showed no problems.

On Sat, 2010-02-27 at 04:35 +0000, Chromakode wrote:
> Review: Needs Fixing
> This branch is not ready!
>
> It currently uses the localization domain "fslint", apparently ripped straight from an example. In addition, it munges already corrected headers, and steps on the definition of is_interactive in boots/lib/ui/generic.py -- reintroducing a bug.
>
> Please make sure to review the complete diffs every time you merge -- and critically look at the code! This was a bit sloppy.

--

*You can find me on IM as well
bedlamoid (Yahoo,AIM, MSN)
ken.brotherton@gmail (GTalk)
http://www.myspace.com/broken_broken
http://www.facebook.com/people/Ken-Brotherton/691662047

« Back to merge proposal