Merge lp:~kelemeng/ubuntuone-installer/bug856728 into lp:ubuntuone-installer

Proposed by Gabor Kelemen
Status: Merged
Approved by: dobey
Approved revision: 22
Merged at revision: 26
Proposed branch: lp:~kelemeng/ubuntuone-installer/bug856728
Merge into: lp:ubuntuone-installer
Diff against target: 21 lines (+2/-2)
1 file modified
ubuntuone/installer/gui.py (+2/-2)
To merge this branch: bzr merge lp:~kelemeng/ubuntuone-installer/bug856728
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+77810@code.launchpad.net

Commit message

Mark two overlooked strings for translation.

To post a comment you must log in.
19. By dobey

Bump version for development

Revision history for this message
dobey (dobey) wrote :

+ _(u'This distribution is not supported by Ubuntu One.'))

+ comment=_(u'added by Ubuntu One installer'),

These two strings should not be translated.

review: Needs Fixing
20. By dobey

Bump version to 3.1

21. By Gabor Kelemen

Mark forgotten strings for translation. LP: #856728

22. By Gabor Kelemen

Do not mark strings for translation, as requested

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

Modified. Those strings looked like they have some slight chance to show up somewhere to users.

Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/installer/gui.py'
--- ubuntuone/installer/gui.py 2011-09-14 19:50:24 +0000
+++ ubuntuone/installer/gui.py 2011-11-16 00:29:24 +0000
@@ -150,7 +150,7 @@
150 self.__action_area.add(self.__cancel_button)150 self.__action_area.add(self.__cancel_button)
151 self.__cancel_button.show()151 self.__cancel_button.show()
152152
153 self.__main_button = Gtk.Button.new_with_mnemonic('I_nstall')153 self.__main_button = Gtk.Button.new_with_mnemonic(_(u'I_nstall'))
154 self.__main_button.set_image(Gtk.Image.new_from_stock(154 self.__main_button.set_image(Gtk.Image.new_from_stock(
155 Gtk.STOCK_OK, Gtk.IconSize.BUTTON))155 Gtk.STOCK_OK, Gtk.IconSize.BUTTON))
156 self.__main_button.connect('clicked', lambda x: self.emit(156 self.__main_button.connect('clicked', lambda x: self.emit(
@@ -160,7 +160,7 @@
160 self.__main_button.show()160 self.__main_button.show()
161161
162 self.__lm_button = Gtk.LinkButton.new_with_label(162 self.__lm_button = Gtk.LinkButton.new_with_label(
163 'https://one.ubuntu.com/', 'Learn more')163 'https://one.ubuntu.com/', _(u'Learn more'))
164 self.__action_area.add(self.__lm_button)164 self.__action_area.add(self.__lm_button)
165 self.__action_area.set_child_secondary(self.__lm_button, True)165 self.__action_area.set_child_secondary(self.__lm_button, True)
166 self.__lm_button.show()166 self.__lm_button.show()

Subscribers

People subscribed via source and target branches