Merge lp:~kelemeng/indicator-printers/bug945547 into lp:indicator-printers/0.1

Proposed by Gabor Kelemen
Status: Merged
Approved by: Charles Kerr
Approved revision: 54
Merge reported by: Lars Karlitski
Merged at revision: not available
Proposed branch: lp:~kelemeng/indicator-printers/bug945547
Merge into: lp:indicator-printers/0.1
Diff against target: 66 lines (+9/-8)
3 files modified
src/indicator-printer-state-notifier.c (+4/-6)
src/indicator-printers-menu.c (+3/-1)
src/indicator-printers.c (+2/-1)
To merge this branch: bzr merge lp:~kelemeng/indicator-printers/bug945547
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+95731@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Looks good

review: Approve
Revision history for this message
Lars Karlitski (larsu) wrote :

Thanks for the patch, Gabor!

And thank you Charles for reviewing it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/indicator-printer-state-notifier.c'
--- src/indicator-printer-state-notifier.c 2012-02-16 16:36:05 +0000
+++ src/indicator-printer-state-notifier.c 2012-03-03 12:13:20 +0000
@@ -120,16 +120,14 @@
120 GtkWidget *image;120 GtkWidget *image;
121 gchar *primary_text;121 gchar *primary_text;
122 gchar *secondary_text;122 gchar *secondary_text;
123 const gchar *fmt;
124123
125 image = gtk_image_new_from_icon_name ("printer", GTK_ICON_SIZE_DIALOG);124 image = gtk_image_new_from_icon_name ("printer", GTK_ICON_SIZE_DIALOG);
126 primary_text = g_strdup_printf (reason, printer);125 primary_text = g_strdup_printf (reason, printer);
127126
128 if (njobs == 1)127 secondary_text = g_strdup_printf (ngettext(
129 fmt = _("You have %d job queued to print on this printer.");128 "You have %d job queued to print on this printer.",
130 else129 "You have %d jobs queued to print on this printer.", njobs),
131 fmt = _("You have %d jobs queued to print on this printer.");130 njobs);
132 secondary_text = g_strdup_printf (fmt, njobs);
133131
134 dialog = g_object_new (GTK_TYPE_MESSAGE_DIALOG,132 dialog = g_object_new (GTK_TYPE_MESSAGE_DIALOG,
135 "title", _("Printing Problem"),133 "title", _("Printing Problem"),
136134
=== modified file 'src/indicator-printers-menu.c'
--- src/indicator-printers-menu.c 2012-02-15 10:40:19 +0000
+++ src/indicator-printers-menu.c 2012-03-03 12:13:20 +0000
@@ -18,6 +18,8 @@
1818
19#include "indicator-printers-menu.h"19#include "indicator-printers-menu.h"
2020
21#include <glib/gi18n.h>
22
21#include <cups/cups.h>23#include <cups/cups.h>
2224
23#include "spawn-printer-settings.h"25#include "spawn-printer-settings.h"
@@ -195,7 +197,7 @@
195197
196 switch (state) {198 switch (state) {
197 case IPP_PRINTER_STOPPED:199 case IPP_PRINTER_STOPPED:
198 dbusmenu_menuitem_property_set (item, "indicator-right", "Paused");200 dbusmenu_menuitem_property_set (item, "indicator-right", _("Paused"));
199 dbusmenu_menuitem_property_set_bool (item, "indicator-right-is-lozenge", FALSE);201 dbusmenu_menuitem_property_set_bool (item, "indicator-right-is-lozenge", FALSE);
200 break;202 break;
201203
202204
=== modified file 'src/indicator-printers.c'
--- src/indicator-printers.c 2012-02-17 18:14:02 +0000
+++ src/indicator-printers.c 2012-03-03 12:13:20 +0000
@@ -22,6 +22,7 @@
22#include "indicator-menu-item.h"22#include "indicator-menu-item.h"
23#include "dbus-names.h"23#include "dbus-names.h"
2424
25#include <glib/gi18n.h>
25#include <gtk/gtk.h>26#include <gtk/gtk.h>
2627
27#include <libindicator/indicator.h>28#include <libindicator/indicator.h>
@@ -287,7 +288,7 @@
287 gtk_widget_show (GTK_WIDGET (image));288 gtk_widget_show (GTK_WIDGET (image));
288289
289 priv->entry.name_hint = PACKAGE_NAME;290 priv->entry.name_hint = PACKAGE_NAME;
290 priv->entry.accessible_desc = "Printers";291 priv->entry.accessible_desc = _("Printers");
291 priv->entry.menu = GTK_MENU (g_object_ref_sink (menu));292 priv->entry.menu = GTK_MENU (g_object_ref_sink (menu));
292 priv->entry.image = g_object_ref_sink (image);293 priv->entry.image = g_object_ref_sink (image);
293294

Subscribers

People subscribed via source and target branches