Code review comment for lp:~kejun-zhou/lava-android-test/ime

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

By this line
51 +PATTERN = "^\s*(?P<test_case_id>\w+)=(?P<result>\w+)\s*$"
many lines of the output will be matched.
Because the output of "/system/bin/ime list -a" like below:

com.android.inputmethod.latin/.LatinIME:
  mId=com.android.inputmethod.latin/.LatinIME mSettingsActivityName=com.android.inputmethod.latin.Settings
  mIsDefaultResId=0x7f080000
  Service:
    priority=0 preferredOrder=0 match=0x108000 specificIndex=-1 isDefault=false
    ServiceInfo:
      name=com.android.inputmethod.latin.LatinIME
      packageName=com.android.inputmethod.latin
      labelRes=0x7f0b0075 nonLocalizedLabel=null icon=0x0
      enabled=true exported=true processName=com.android.inputmethod.latin
      permission=android.permission.BIND_INPUT_METHOD
      flags=0x0
jp.co.omronsoft.openwnn/.OpenWnnJAJP:
  mId=jp.co.omronsoft.openwnn/.OpenWnnJAJP mSettingsActivityName=jp.co.omronsoft.openwnn.OpenWnnControlPanelJAJP
  mIsDefaultResId=0x0
  Service:
    priority=0 preferredOrder=0 match=0x108000 specificIndex=-1 isDefault=false
    ServiceInfo:
      name=jp.co.omronsoft.openwnn.OpenWnnJAJP
      packageName=jp.co.omronsoft.openwnn
      labelRes=0x0 nonLocalizedLabel=Japanese IME icon=0x0
      enabled=true exported=true processName=jp.co.omronsoft.openwnn
      permission=android.permission.BIND_INPUT_METHOD
      flags=0x0
com.android.inputmethod.pinyin/.PinyinIME:
  mId=com.android.inputmethod.pinyin/.PinyinIME mSettingsActivityName=com.android.inputmethod.pinyin.SettingsActivity
  mIsDefaultResId=0x7f060000
  Service:
    priority=0 preferredOrder=0 match=0x108000 specificIndex=-1 isDefault=false
    ServiceInfo:
      name=com.android.inputmethod.pinyin.PinyinIME
      packageName=com.android.inputmethod.pinyin
      labelRes=0x7f090000 nonLocalizedLabel=null icon=0x0
      enabled=true exported=true processName=com.android.inputmethod.pinyin
      permission=android.permission.BIND_INPUT_METHOD
      flags=0x0
$

Please confirm what is you want.

review: Needs Fixing

« Back to merge proposal