Merge lp:~kees/libunity/remote-search-none into lp:libunity

Proposed by Kees Cook
Status: Needs review
Proposed branch: lp:~kees/libunity/remote-search-none
Merge into: lp:libunity
Diff against target: 12 lines (+1/-1)
1 file modified
data/com.canonical.Unity.Lenses.gschema.xml.in.in (+1/-1)
To merge this branch: bzr merge lp:~kees/libunity/remote-search-none
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+134180@code.launchpad.net

Description of the change

Default online search preferences to disabled until there is a UI for selective control with sensible user notification about the privacy implications of enabling this (LP: #1073114).

To post a comment you must log in.
Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

Looks like a pretty straigtforward change that addresses the default nature of the feature which gave rise to the bug and has raised concern.

Hopefully the Unity Team will review this.

Revision history for this message
Nathan Williams (nathwill-deactivatedaccount-deactivatedaccount) wrote :

+1

opt-in would alleviate much of the ire over this feature

Revision history for this message
Michael Hall (mhall119) wrote :

This changes an important default setting that has a significant impact on the user experience presented. Have you discussed and gotten approval from the design team for this functionality change?

Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

> This changes an important default setting that has a significant impact on the
> user experience presented. Have you discussed and gotten approval from the
> design team for this functionality change?

The proposer of this MP sits on the Ubuntu Technical Board.

Unmerged revisions

153. By Kees Cook on 2012-11-13

Default online search preferences to disabled until there is a UI for
selective control with sensible user notification about the privacy
implications of enabling this (LP: #1073114).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/com.canonical.Unity.Lenses.gschema.xml.in.in'
2--- data/com.canonical.Unity.Lenses.gschema.xml.in.in 2012-09-25 15:10:07 +0000
3+++ data/com.canonical.Unity.Lenses.gschema.xml.in.in 2012-11-13 19:36:25 +0000
4@@ -1,7 +1,7 @@
5 <schemalist>
6 <schema path="/com/canonical/unity/lenses/" id="com.canonical.Unity.Lenses" gettext-domain="libunity">
7 <key type="s" name="remote-content-search">
8- <default>'all'</default>
9+ <default>'none'</default>
10 <choices><choice value='all'/><choice value='none'/></choices>
11 <summary>Content fetching from remote source preference.</summary>
12 <description>"all" is to enable the supported default lens to search from remote and commercial sources. "none" will indicate the lenses to not perform that remote search at all.</description>

Subscribers

People subscribed via source and target branches