Code review comment for lp:~keegan-csmith/ibid/hg-505320

Revision history for this message
Max Rabkin (max-rabkin) wrote :

@match(r'^(?:hgrepos|hgrepositories)$') is not very human-friendly, and it should use simple matches (as should the other regex).

def get_cache_directory(plugin_name = None)

PEP 8 doesn't have spaces around "=" here.

I haven't looked at the code itself yet.

review: Needs Fixing

« Back to merge proposal