Code review comment for lp:~kdub/mir/upgrade-anativewindow

The changes look good, some nitpicks left:

29 +std::shared_ptr<EGLNativeWindowType> mcla::AndroidClientPlatform::create_egl_native_window(ClientSurface * surface)

The fate of '*' still hasn't been decided.

75 + virtual void driver_returns_buffer(ANativeWindowBuffer*, int fence_fd ) = 0;
136 +void mcla::ClientSurfaceInterpreter::driver_returns_buffer(ANativeWindowBuffer*, int /*fence_fd*/ )
206 + void driver_returns_buffer(ANativeWindowBuffer*, int fence_fd );

Space before right parenthesis.

421 + explicit MirNativeWindow(std::shared_ptr<AndroidDriverInterpreter> interpreter);

shared_ptr const& ?

432 + std::shared_ptr<AndroidDriverInterpreter> driver_interpreter;

shared_ptr const ?

1143 + EXPECT_EQ(returned_buffer, &buffer);
1171 + EXPECT_EQ(tmp_format, format);

Expected/Actual in reverse order.