Code review comment for lp:~kdub/mir/split-mesa

Hrm.

+mir::UniqueModulePtr<mir::graphics::RenderingPlatform> create_rendering_platform(
+ std::shared_ptr<mir::options::Option> const& options,
+ std::shared_ptr<mir::graphics::PlatformAuthentication> const& platform_authentication)

Where did this create_rendering_platform() signature come from? I thought we were going to dynamic_cast<> the DisplayPlatform?

Is there an urgent need for this MP to land, or can we fix the base API first?

(There are other issues, like the entirely unnecessary auth_fd(), but that's pre-existing)