Mir

Code review comment for lp:~kdub/mir/rw-fences

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Not a thorough review, but one thing that caught my eye:

TEST_F(NativeBuffer, access_for_read_while_being_read)
TEST_F(NativeBuffer, access_for_read_while_being_written)
...etc

The names describe what the arrangement and actions of the test are (while being read, try to read), but not what the expected behavior should be (does not wait). Therefore the names are not as informative as they could be. Perhaps something like:

TEST_F(NativeBuffer, does_not_wait_for_read_access_while_being_read)

« Back to merge proposal