Mir

Code review comment for lp:~kdub/mir/resettable-buffer-cb

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

LGTM.

Nit : Line #110 (extraneous space) and line #116 (split at the comma) could use better formatting.
        +/** Reassign the callback that the MirBuffer will call when the buffer is
107 + * available for use again
108 + * \param [in] buffer The buffer
109 + * \param [in] available_callback The callback called when the buffer
110 + * is available
111 + * \param [in] available_context The context for the available_callback
112 + **/
113 +
114 +void mir_buffer_set_callback(
115 + MirBuffer* buffer,
116 + mir_buffer_callback available_callback, void* available_context);

review: Approve

« Back to merge proposal