Mir

Code review comment for lp:~kdub/mir/no-display-attribs

  1. no-display-attribs
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > 646 - EXPECT_FALSE(outputs[1].used);
> > 647 + EXPECT_TRUE(outputs[1].used);
> >
> > Why? It isn't clear to me why this expectation changes as a result of
> changing
> > the way data is held.
>
> Launchpad lost my comment yesterday...
> It is a correction of incorrect behavior. The external monitor was always
> reported as not used (even when on and used), which I noticed while going
> through and fixing things up to remove the DisplayAttribs struct.

OK

review: Approve

« Back to merge proposal