Code review comment for lp:~kdub/mir/nbs-option
Revision history for this message
| Kevin DuBois (kdub) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
With the EventSink to BufferSink change, this is some correction that should have happened in rev2765 when EventSink was kept private, and BufferSink was made a public header. Its better to give BufferMap a BufferSink then to change the factory to take an EventSink, as all the BufferMap needs is the BufferSink interfaces.
--nbuffers is a transitional option useful to testing that will go away eventually. It will (probably) be around for a release or three while we ensure the new system is up-to-par with the old.