Mir

Code review comment for lp:~kdub/mir/multiple-bufferstream-api

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

===
45 + * \param [in] size The number of elements in the streams array.
===

doxygen comment still refers to size instead of num_streams.

"[0;32m[ RUN ] BufferStreamArrangement.arrangements_are_applied
/tmp/buildd/mir-0.14.0bzr2469pkg0wily2729+autopilot0/tests/acceptance-tests/test_buffer_stream_arrangement.cpp:236: Failure
Value of: ordering->wait_for_another_post_within(1s)
Actual: false
Expected: true
timed out waiting for another post"

===
561 + EXPECT_TRUE(ordering->wait_for_another_post_within(1s))
===
I guess running with Valgrind in CI needs more than 1s.

Looks good otherwise.

review: Needs Fixing

« Back to merge proposal