Mir

Code review comment for lp:~kdub/mir/multiple-bufferstream-api

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

===
45 + * \param [in] size The size of streams.

49 + unsigned int size);
===

Maybe change size to num_elements?
"The number of elements in the streams array" to avoid confusion?

===
148 +void mir_surface_spec_set_streams(MirSurfaceSpec* spec, MirBufferStreamInfo* streams, unsigned int size)
===

The implementation should validate its preconditions with mir::require(mir_buffer_stream_is_valid(...)) for all buffer streams.

===
172 +MIR_CLIENT_9.1 { # New in Mir 0.14
173 + global:
174 + mir_surface_spec_set_streams;
175 +} MIR_CLIENT_9;
===

No need for a 9.1 stanza as we haven't released anything with MIR_CLIENT_9 yet.

review: Needs Fixing

« Back to merge proposal