Mir

Code review comment for lp:~kdub/mir/hwc-integration

  1. hwc-integration
  2. Merge into trunk
Revision history for this message
Kevin DuBois (kdub) wrote :

> 210 + [](hwc_composer_device_1* device)
>
> Indentation is too deep.
>
> 634 + EXPECT_NO_THROW({
> 890 + EXPECT_NO_THROW({
> 901 + EXPECT_NO_THROW(
> ... and at other places
>
> As discussed in a previous MP, there is no real benefit in using
> EXPECT_NO_THROW.
>
I can eliminate these, although it feels strange to have a test where the expectation is just 'dont explode the system'. I'll find another way of stating the intention of the test.

« Back to merge proposal