Mir

Code review comment for lp:~kdub/mir/gbm-ext-v2

  1. gbm-ext-v2
  2. Merge into development-branch
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(5) A bunch of these functions take MirBuffer as an 'in' parameter only so should take const pointers, no?
   typedef uint32_t (*MirBufferExtFormat)(MirBuffer* buffer);

(6) Given the header is GBM-specific, is it a good idea to define callback types that are not GBM-specific in name inside it?

review: Needs Fixing

« Back to merge proposal