Mir

Code review comment for lp:~kdub/mir/gbm-ext-v2

Revision history for this message
Chris Halse Rogers (raof) wrote :

(Non-blocking)
+}
+catch (...)
+{
+ return INT64_MAX;
+}

Probably (slightly) safer to return 0 here - 0 means the contents are undefined, so the client will have to do more work but is guaranteed to render correctly.

Also, uint64_t? This is almost always going to have a range of 0-3, and cannot possibly go beyond the tens of thousands (buffers will be on the order of megabytes, we're definitely not going to give a client > 10GB of VRAM just for window buffers!)

Is there a reason you picked uint64_t rather than uint32_t?

review: Approve

« Back to merge proposal