Mir

Code review comment for lp:~kdub/mir/gbm-cleanup

  1. gbm-cleanup
  2. Merge into trunk
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

Non-blocking nits:

495 + MirBufferPackage* package)
515 + MirSurfaceParameters* parameters)

Wrong alignment.

588 + static int set_swapinterval_static(MirMesaEGLNativeSurface* surface, int interval);
589 + static int advance_buffer_static(MirMesaEGLNativeSurface* surface,
590 + MirBufferPackage* package);
591 +
592 + static int get_parameters_static(MirMesaEGLNativeSurface* surface,
593 + MirSurfaceParameters* parameters);

These could be private.

review: Approve

« Back to merge proposal