Code review comment for lp:~kdub/mir/fix-1579076
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Sorry, I tried and can't easily test this right now, due to too many recent changes in buffer_vault.cpp to unwind and try one thing at a time.
I am concerned we're going downhill with code quality and maturity though. This branch has been forced into lp:mir/0.23 already without review or approval, apparently in a rush to release Mir 0.23.0 while we haven't given the new NBS code time to cool down, stabilize and mature yet. This is not good practice.