Mir

Code review comment for lp:~kdub/mir/fix-1563278

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Just nits:

 }
-
TEST_F(SurfaceStack, occludes_not_rendered_surface)

I'd like to keep that whitespace.

~~~~

+ stub_buffer_stream1 = std::make_shared<mtd::StubBufferStream>();
+ stub_buffer_stream2 = std::make_shared<mtd::StubBufferStream>();
+ stub_buffer_stream3 = std::make_shared<mtd::StubBufferStream>();
...
+ std::shared_ptr<mc::BufferStream> stub_buffer_stream1;
+ std::shared_ptr<mc::BufferStream> stub_buffer_stream2;
+ std::shared_ptr<mc::BufferStream> stub_buffer_stream3;

I think test fixtures are a great place for in-class initializers - half the lines used here and only one place to look.

~~~~

 }
-
//test associated with lp:1290306, 1293896, 1294048, 1294051, 1294053

I'd like to keep that whitespace.

review: Needs Fixing

« Back to merge proposal