Just nits:
} - TEST_F(SurfaceStack, occludes_not_rendered_surface)
I'd like to keep that whitespace.
~~~~
+ stub_buffer_stream1 = std::make_shared<mtd::StubBufferStream>(); + stub_buffer_stream2 = std::make_shared<mtd::StubBufferStream>(); + stub_buffer_stream3 = std::make_shared<mtd::StubBufferStream>(); ... + std::shared_ptr<mc::BufferStream> stub_buffer_stream1; + std::shared_ptr<mc::BufferStream> stub_buffer_stream2; + std::shared_ptr<mc::BufferStream> stub_buffer_stream3;
I think test fixtures are a great place for in-class initializers - half the lines used here and only one place to look.
} - //test associated with lp:1290306, 1293896, 1294048, 1294051, 1294053
« Back to merge proposal
Just nits:
} SurfaceStack, occludes_ not_rendered_ surface)
-
TEST_F(
I'd like to keep that whitespace.
~~~~
+ stub_buffer_stream1 = std::make_ shared< mtd::StubBuffer Stream> (); shared< mtd::StubBuffer Stream> (); shared< mtd::StubBuffer Stream> (); ptr<mc: :BufferStream> stub_buffer_ stream1; ptr<mc: :BufferStream> stub_buffer_ stream2; ptr<mc: :BufferStream> stub_buffer_ stream3;
+ stub_buffer_stream2 = std::make_
+ stub_buffer_stream3 = std::make_
...
+ std::shared_
+ std::shared_
+ std::shared_
I think test fixtures are a great place for in-class initializers - half the lines used here and only one place to look.
~~~~
}
-
//test associated with lp:1290306, 1293896, 1294048, 1294051, 1294053
I'd like to keep that whitespace.