Merge lp:~kdub/mir/fix-1369763 into lp:mir
Status: | Merged |
---|---|
Approved by: | Daniel van Vugt |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3759 |
Proposed branch: | lp:~kdub/mir/fix-1369763 |
Merge into: | lp:mir |
Diff against target: |
266 lines (+71/-2) 17 files modified
include/platform/mir/graphics/renderable.h (+1/-0) src/include/server/mir/compositor/buffer_stream.h (+1/-0) src/platform/symbols.map (+1/-0) src/platforms/android/server/hwc_device.cpp (+2/-1) src/platforms/android/utils/render_overlays.cpp (+5/-0) src/platforms/android/utils/test_android_hardware_sanity.cpp (+4/-0) src/server/compositor/stream.cpp (+5/-0) src/server/compositor/stream.h (+1/-0) src/server/graphics/software_cursor.cpp (+5/-0) src/server/input/touchspot_controller.cpp (+6/-0) src/server/scene/basic_surface.cpp (+5/-0) tests/include/mir/test/doubles/fake_renderable.h (+5/-0) tests/include/mir/test/doubles/mock_buffer_stream.h (+1/-0) tests/include/mir/test/doubles/mock_renderable.h (+1/-0) tests/include/mir/test/doubles/stub_buffer_stream.h (+4/-1) tests/include/mir/test/doubles/stub_renderable.h (+13/-0) tests/unit-tests/platforms/android/server/test_hwc_device.cpp (+11/-0) |
To merge this branch: | bzr merge lp:~kdub/mir/fix-1369763 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
Brandon Schaefer (community) | Approve | ||
Mir CI Bot | continuous-integration | Approve | |
Cemil Azizoglu (community) | Approve | ||
Alexandros Frantzis (community) | Needs Fixing | ||
Review via email: mp+307945@code.launchpad.net |
Commit message
android: disable overlays when a swapinterval 0 client is part of the RenderableList. This won't affect the overlay percentage for usc/u8, as u8 runs swapinterval 1.
mg::Renderable providing swapinterval information is useful to android to fix this bug, as well as for nested-passthrough, where nested-passthrough has to coordinate the passthrough surface with the host server, so the host server doesn't end up grabbing all the buffers from the passthrough surface.
platform abi number was already increased for the 0.25 series.
Fixes: LP: #1369763
Description of the change
android: disable overlays when a swapinterval 0 client is part of the RenderableList. This won't affect the overlay percentage for usc/u8, as u8 runs swapinterval 1.
mg::Renderable providing swapinterval information is useful to android to fix this bug, as well as for nested-passthrough, where nested-passthrough has to coordinate the passthrough surface with the host server, so the host server doesn't end up grabbing all the buffers from the passthrough surface.
platform abi number was already increased for the 0.25 series.
Fixes: LP: #1369763
This can go in the 'why didn't I think of this before" pile.