Code review comment for lp:~kdub/mir/fix-1369763

Daniel van Vugt (vanvugt) wrote :

Thanks for looking at this. Just wondering; if you're disabling overlays for anything that's interval 0 on the server side and we hope to make everything on the server side interval 0 (when interval 1 becomes a function of the libmirclient), then won't we need to revert this? Would it not just be a better idea to leave the bug unresolved until a final solution is feasible?

By landing this now, we create a regression that's worse than the bug itself. That is a future mirserver will never overlay unless we remember to also revert this change.

review: Needs Information

« Back to merge proposal