Mir

Code review comment for lp:~kdub/mir/fix-1342029

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2014-07-29:

1 === added file 'include/test/mir_test_framework/binary_path.h'

I know we don't need it (there are only declarations) but it is traditional to use include guards.

~~~~

6 + * Copyright © 2013 Canonical Ltd.
...
21 + * Christopher James Halse Rogers <email address hidden>

90 + * Copyright © 2013 Canonical Ltd.
...
105 + * Christopher James Halse Rogers <email address hidden>

Really?

~~~~

27 +std::string binary_path();

I don't have a good suggestion, but even slightly out of context this function name is uninformative.

review: Needs Fixing