Mir

Code review comment for lp:~kdub/mir/fix-1299977-take3

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes it does appear people are writing their own compositors despite us recommending against it. And I too want to resolve the blurry seams that have formed between compositor classes and renderers.

OK I can make suggestions for moving forward:

(1) Remove all references to bug 1299977. Because what's proposed here is only for demo shell, and not a generic fix for bug 1299977. We can do enough work to unblock overlay enablement without waiting for a full fix of bug 1299977 to land.

(2) Make demo-shell's flagging of occlusions simple and dumb, so that the word "decoration" is never mentioned. Just allow overlays for the surface that's "on top" (last on the render list). A generic solution which accounts for decorations more carefully will come later. You don't need to wait for that to unblock.

We can argue about the existence of DefaultDisplayByfferCompositor another day.

It's a little bit silly that demo shell should block unity8 progress so let's get over this hump with minimal code change (which also makes it more likely to get backported to stable series 0.5 for RTM).

review: Needs Fixing

« Back to merge proposal