Mir

Code review comment for lp:~kdub/mir/fix-1270245

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+ return device_name == std::string{"krillin"} || device_name == std::string{"mx4"};

I know there's existing code in this style, but it seem unnecessary to construct temporary string objects for these constants. As std::string has an operator==(std::string const&, const CharT*) the same test can be written more efficiently:

    return device_name == "krillin" || device_name == "mx4";

review: Abstain

« Back to merge proposal