Mir

Code review comment for lp:~kdub/mir/egl-connection-for-offscreen

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

(1) Build failure per above.

(2) "EGLAccess" feels like a poor choice of words. Looking at where it is used (https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglGetDisplay.xhtml), I would say the object from which you get egl_native_display() is an EGL platform, so suggest "EGLPlatform" instead of "EGLAccess".

review: Needs Fixing

« Back to merge proposal