Mir

Code review comment for lp:~kdub/mir/display-groups

  1. display-groups
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

262 +class ConfigurableDisplayBuffer : public graphics::DisplayBuffer,
263 + public graphics::DisplayGroup
...
469 +class DisplayBuffer : public graphics::DisplayBuffer,
470 + public graphics::DisplayGroup

I don't feel I understand the relationship between graphics::DisplayBuffer and graphics::DisplayGroup.

My gut says there's a composite pattern hidden in there somewhere, but that the interfaces are not quite right.

review: Abstain

« Back to merge proposal