Code review comment for lp:~kdub/mir/current-buffer-id-fix

11: [----------] 2 tests from ThreadedDispatcherDeathTest
11: [ RUN ] ThreadedDispatcherDeathTest.exceptions_in_threadpool_trigger_termination
11: Running main() from main.cpp
no failure on phone but instead on clang: maybe the thread was not scheduled:

11: [ OK ] ThreadedDispatcherDeathTest.exceptions_in_threadpool_trigger_termination (166 ms)
11: [ RUN ] ThreadedDispatcherDeathTest.destroying_dispatcher_from_a_callback_is_an_error
11:
11: [WARNING] /usr/src/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads.
11: /mir/tests/unit-tests/dispatch/test_threaded_dispatcher.cpp:385: Failure
11: Death test: { md::ThreadedDispatcher* dispatcher; auto dispatchable = std::make_shared<mt::TestDispatchable>([&dispatcher]() { delete dispatcher; }); dispatchable->trigger(); dispatcher = new md::ThreadedDispatcher("Death thread", dispatchable); std::this_thread::sleep_for(10s); }
11: Result: failed to die.
11: Error msg:
11: [ DEATH ]
11: [ FAILED ] ThreadedDispatcherDeathTest.destroying_dispatcher_from_a_callback_is_an_error (10006 ms)
11: [----------] 2 tests from ThreadedDispatcherDeathTest (10172 ms total)