Mir

Code review comment for lp:~kdub/mir/connect-fallback-to-hwc-device

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Just nits:

747 +#include "mir_test_doubles/stub_renderable_list_compositor.h"

Unused.

~~~~

773 + EXPECT_CALL(mock_compositor, render(Ref(renderlist),_))
774 + .InSequence(seq)
775 + .WillOnce(Invoke([](mg::RenderableList const&, mga::SwappingGLContext const& cont)
776 + {cont.swap_buffers();}));

The lambda body should be further indented than the surrounding .WillOnce call. (Or on the same line.)

review: Needs Fixing

« Back to merge proposal