I'm happy to see this land now; it seems to be a pretty critical fix for our downstreams.
That said, this should be marked as technical debt - I'd suggest a comment on the test saying that it's testing temporary behaviour, and a TODO in start()/stop()?
I'm happy to see this land now; it seems to be a pretty critical fix for our downstreams.
That said, this should be marked as technical debt - I'd suggest a comment on the test saying that it's testing temporary behaviour, and a TODO in start()/stop()?