Mir

Code review comment for lp:~kdub/mir/android-internal-client

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'm not clear on some of the semantics - e.g. what does this do and why does it need a surface:

266 + virtual std::shared_ptr<InternalClient> create_internal_client(std::shared_ptr<frontend::Surface> const&) = 0;

But it seems to work without anything that leaps out as ugly.

review: Approve

« Back to merge proposal