1402 + if (display_type == mga::DisplayType::HWC_1_1) 1403 + { 1404 + return fb_factory->create_hwc1_1_gpu_display(); 1405 + } else { 1406 + return fb_factory->create_gpu_display(); 1407 + }
I'm not sure why we need DisplayType to support this use.
Polymorphism (or a function pointer) would seem more natural.
Anyway "} else {" appears a few times and isn't our style.
« Back to merge proposal
1402 + if (display_type == mga::DisplayTyp e::HWC_ 1_1) >create_ hwc1_1_ gpu_display( ); >create_ gpu_display( );
1403 + {
1404 + return fb_factory-
1405 + } else {
1406 + return fb_factory-
1407 + }
I'm not sure why we need DisplayType to support this use.
Polymorphism (or a function pointer) would seem more natural.
Anyway "} else {" appears a few times and isn't our style.