Mir

Code review comment for lp:~kdub/mir/RFC-surface-arrangements

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

43+/** Reorder the streams associated with the spec.

It isn't "reorder"ing any more. It is "assign"ing.

~~~~

41+void mir_surface_buffer_stream_info_at(MirSurface* surface, unsigned int index, MirBufferStreamInfo*);
...
57+void mir_surface_spec_reorder_streams(MirSurfaceSpec* spec, MirBufferStreamInfo* streams, unsigned int size);

These seem oddly asymmetric. Can't we have

size_t mir_surface_buffer_get_streams(MirSurface* surface, MirBufferStreamInfo* streams, size_t count);

and

void mir_surface_spec_set_streams(MirSurfaceSpec* spec, MirBufferStreamInfo* streams, size_t count);

« Back to merge proposal