Merge lp:~karni/ubuntuone-android-music/fix-music-stutter into lp:ubuntuone-android-music

Proposed by Michał Karnicki
Status: Merged
Approved by: Chad Miller
Approved revision: 566
Merged at revision: 566
Proposed branch: lp:~karni/ubuntuone-android-music/fix-music-stutter
Merge into: lp:ubuntuone-android-music
Diff against target: 55 lines (+18/-2)
3 files modified
project.properties (+1/-1)
src/net/sourceforge/subsonic/androidapp/service/DownloadServiceImpl.java (+1/-1)
src/net/sourceforge/subsonic/androidapp/util/Util.java (+16/-0)
To merge this branch: bzr merge lp:~karni/ubuntuone-android-music/fix-music-stutter
Reviewer Review Type Date Requested Status
Chad Miller (community) Approve
Review via email: mp+105955@code.launchpad.net

Description of the change

Hold high performance WiFi lock on devices with API >= 12 (HONEYCOMB_MR1), in case the screen is off and WiFi performance may decrease.

See:
http://developer.android.com/reference/android/net/wifi/WifiManager.html#WIFI_MODE_FULL_HIGH_PERF

To post a comment you must log in.
Revision history for this message
Chad Miller (cmiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'project.properties'
--- project.properties 2012-03-02 19:31:24 +0000
+++ project.properties 2012-05-16 11:10:22 +0000
@@ -9,4 +9,4 @@
99
10android.library.reference.1=../../ubuntuone-android-sso/ubuntuone-android-sso10android.library.reference.1=../../ubuntuone-android-sso/ubuntuone-android-sso
11# Project target.11# Project target.
12target=android-812target=android-12
1313
=== modified file 'src/net/sourceforge/subsonic/androidapp/service/DownloadServiceImpl.java'
--- src/net/sourceforge/subsonic/androidapp/service/DownloadServiceImpl.java 2011-10-24 19:10:31 +0000
+++ src/net/sourceforge/subsonic/androidapp/service/DownloadServiceImpl.java 2012-05-16 11:10:22 +0000
@@ -159,7 +159,7 @@
159 wakeLock.setReferenceCounted(false);159 wakeLock.setReferenceCounted(false);
160 160
161 WifiManager wm = (WifiManager)getSystemService(Context.WIFI_SERVICE);161 WifiManager wm = (WifiManager)getSystemService(Context.WIFI_SERVICE);
162 wifiLock = wm.createWifiLock(this.getClass().getName());162 wifiLock = wm.createWifiLock(Util.getWifiLockFlag(), this.getClass().getName());
163 wifiLock.setReferenceCounted(false);163 wifiLock.setReferenceCounted(false);
164164
165 instance = this;165 instance = this;
166166
=== modified file 'src/net/sourceforge/subsonic/androidapp/util/Util.java'
--- src/net/sourceforge/subsonic/androidapp/util/Util.java 2012-04-17 14:43:06 +0000
+++ src/net/sourceforge/subsonic/androidapp/util/Util.java 2012-05-16 11:10:22 +0000
@@ -65,7 +65,10 @@
65import android.media.AudioManager;65import android.media.AudioManager;
66import android.net.ConnectivityManager;66import android.net.ConnectivityManager;
67import android.net.NetworkInfo;67import android.net.NetworkInfo;
68import android.net.wifi.WifiManager;
68import android.os.Build;69import android.os.Build;
70import android.os.Build.VERSION;
71import android.os.Build.VERSION_CODES;
69import android.os.Environment;72import android.os.Environment;
70import android.os.Handler;73import android.os.Handler;
71import android.util.Log;74import android.util.Log;
@@ -873,4 +876,17 @@
873 })876 })
874 .show();877 .show();
875 }878 }
879
880 private static int wifiLockFlag = WifiManager.WIFI_MODE_FULL;
881
882 static {
883 int sdk = Integer.valueOf(VERSION.SDK);
884 if (sdk >= VERSION_CODES.HONEYCOMB_MR1) {
885 wifiLockFlag = WifiManager.WIFI_MODE_FULL_HIGH_PERF;
886 }
887 }
888
889 public static int getWifiLockFlag() {
890 return wifiLockFlag;
891 }
876}892}

Subscribers

People subscribed via source and target branches

to status/vote changes: