Code review comment for lp:~karl-qdh/ubuntu/maverick/libindicator/absfilename-ibus-bug564034
Revision history for this message
| David Barth (dbarth) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
THe general logic looks right.
Style issue: g_return_if_fail shouldn't be used since it would catch a runtime error (as opposed to a programming error).