Merge lp:~karl-qdh/indicator-datetime/alwaysshowcalendar into lp:indicator-datetime/0.3

Proposed by Karl Lattimer
Status: Merged
Merged at revision: 82
Proposed branch: lp:~karl-qdh/indicator-datetime/alwaysshowcalendar
Merge into: lp:indicator-datetime/0.3
Diff against target: 20 lines (+4/-3)
1 file modified
src/datetime-service.c (+4/-3)
To merge this branch: bzr merge lp:~karl-qdh/indicator-datetime/alwaysshowcalendar
Reviewer Review Type Date Requested Status
Ted Gould Pending
Review via email: mp+55116@code.launchpad.net

Description of the change

Don't make showing the calendar conditional on evolution being installed. The calendar will not be hooked up to any event handlers and therefore will do nothing.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c 2011-03-23 12:03:21 +0000
+++ src/datetime-service.c 2011-03-28 10:24:23 +0000
@@ -364,12 +364,13 @@
364check_for_calendar (gpointer user_data)364check_for_calendar (gpointer user_data)
365{365{
366 g_return_val_if_fail (calendar != NULL, FALSE);366 g_return_val_if_fail (calendar != NULL, FALSE);
367367 // Always enable the calendar even if it does nothing
368 dbusmenu_menuitem_property_set_bool(calendar, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);
369 dbusmenu_menuitem_property_set_bool(calendar, DBUSMENU_MENUITEM_PROP_VISIBLE, TRUE);
370
368 gchar *evo = g_find_program_in_path("evolution");371 gchar *evo = g_find_program_in_path("evolution");
369 if (evo != NULL) {372 if (evo != NULL) {
370 g_debug("Found the calendar application: %s", evo);373 g_debug("Found the calendar application: %s", evo);
371 dbusmenu_menuitem_property_set_bool(calendar, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);
372 dbusmenu_menuitem_property_set_bool(calendar, DBUSMENU_MENUITEM_PROP_VISIBLE, TRUE);
373374
374 dbusmenu_menuitem_property_set_bool(date, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);375 dbusmenu_menuitem_property_set_bool(date, DBUSMENU_MENUITEM_PROP_ENABLED, TRUE);
375 g_signal_connect (G_OBJECT(date), DBUSMENU_MENUITEM_SIGNAL_ITEM_ACTIVATED,376 g_signal_connect (G_OBJECT(date), DBUSMENU_MENUITEM_SIGNAL_ITEM_ACTIVATED,

Subscribers

People subscribed via source and target branches